DittoETH

Ditto
DeFiFoundryOracle
55,000 USDC
View results
Submission Details
Severity: low
Invalid

Lack of empty string check

Summary-Low

Lack of empty string check

Vulnerability Details

Constructor does not check for empty string that can lead to deploying ERC20 contract without setting name and symbol.

Impact

ERC20 tokens will be minted without any name and symbol that will create difficulty in identifying the token.

Tools Used

Manual code Review

Recommendations

Place condition inside constructor to check for empty string.

constructor(address diamondAddr, string memory name, string memory symbol)
ERC20(name, symbol)
{
+ require(bytes(name).length != 0, empty name);
+ require(bytes(symbol).length != 0, string name);
diamond = diamondAddr;
Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Admin Input/call validation

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.