Submission Details
Severity:
Missing constructor cUsd zero-address checks
Summary
There is a missing check in a number of facets that cusd is not a zero address which could allow immutable cusd to be mistakenly set to 0 address.
Vulnerability Details
The constructors in the following facets are affected:
ExitShortFacet
MarginCallPrimaryFacet
ShortRecordFacet
Impact
Any function using the immutable state variable cusd will not work as expected.
Tools Used
Manual Code Review
Recommendations
Add zero address check to the constructor for three facets; ExitShortFacet, MarginCallPrimaryFacet, ShortRecordFacet, before setting cusdto the passed in parameter_cusd```.
constructor(address _cusd) {
require(_cusd != address(0), "CUSD address cannot be zero address");
cusd = _cusd;
}
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.