Submission Details
Severity:
No access control for setting password
Summary
Lack of access control for setPassword().
Vulnerability Details
setPassword() does not check for who the message sender is, therefore anyone can call this function and override the currently stored password.
Impact
Anyone can call setPassword() and override the password that the owner saved, causing the owner to lose his/her password.
Tools Used
Manual review
Recommendations
Add access control to setPassword(), change the function to:
function setPassword(string memory newPassword) external {
if (msg.sender != s_owner) {
revert PasswordStore__NotOwner();
}
s_password = newPassword;
emit SetNetPassword();
}
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.