Submission Details
Severity:
function setPassword allows anyone to update s_password
Summary
The function setPassword allows anyone to update the password.
Vulnerability Details
The function setPassword does not check if the function caller is s_owner, this allows anyone to update s_password.
Impact
Unauthorised update to s_password storage variable.
cast send $PASSWORD_STORE_CONTRACT_ADDRESS "setPassword(string)" "newpassword123" --rpc-url $RPC_URL --private-key $PRIVATE_KEY
Tools Used
Foundry
Slither
Recommendations
Add a check if msg.sender is s_owner before updating s_password
function setPassword(string memory newPassword) external {
+ if (msg.sender != s_owner) {
+ revert PasswordStore__NotOwner();
+ }
s_password = newPassword;
emit SetNetPassword();
}
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.