Submission Details
Severity:
setPassword method can be accessed by anyone!
Summary
Basically anyone can set the password and overwrite the current one.
Vulnerability Details
POC:
function test_everyone_can_set_password() public {
string memory fakePassword = "fakePassword";
vm.prank(address(hAckEr));
passwordStore.setPassword(fakePassword);
vm.prank(owner);
string memory actualPassword = passwordStore.getPassword();
assertEq(actualPassword, fakePassword);
}
Impact
High as anyone can take advantage and change the password.
Tools Used
Foundry, Manula Review
Recommendations
Apply same check as in getPassword() method.
if (msg.sender != s_owner) {
revert PasswordStore__NotOwner();
}
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.