Submission Details
Severity:
Password can be seen by anyone.
Summary
All data stored on the blockchain is public!
Vulnerability Details
POC:
function test_log_password() public {
vm.startPrank(owner);
string memory expectedPassword = "CyfrinIsGreat";
passwordStore.setPassword(expectedPassword);
bytes32 slotValue = vm.load(address(passwordStore),bytes32(uint256(1)));
console.logString(string(abi.encodePacked(slotValue)));
}
Impact
High as the password is visible to anyone and can be used for malitious purposes.
Tools Used
Foundry, Manual Review
Recommendations
Hash the password and store the hash instead.
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-anyone-can-read-storage
Private functions and state variables are only visible for the contract they are defined in and not in derived contracts. In this case private doesn't mean secret/confidential
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.