Submission Details
Severity:
getActivePlayerIndex() will always return zero
Summary
getActivePlayerIndex() will always return zero
Vulnerability Details
In PuppyRaffle.sol::getActivePlayerIndex() the return value is mis placed
Impact
This will mis-lead any functionality depending on getActivePlayerIndex() making it always return 0
Tools Used
manual review
Recommendations
- function getActivePlayerIndex(address player) external view returns (uint256) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == player) {
return i;
}
}
return 0;
}
+ function getActivePlayerIndex(address player) external view returns (uint256) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == player) {
return i;
}
else return 0;
}
}
Updates
Lead Judging Commences
Hamiltonite over 1 year ago
Submission Judgement Published Assigned finding tags:
getActivePlayerIndex can say a player is both entered at slot 0 and inactive
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.