Submission Details
Severity:
Downcasting error
Summary
Downcasting error makes impossible to withdraw fees.
Vulnerability Details
PoC:
uint constant NUMBER_OF_PLAYERS = 100;
modifier playersEnteredMore() {
address[] memory players = new address[](NUMBER_OF_PLAYERS);
for (uint i = 0; i < NUMBER_OF_PLAYERS; i++) {
players[i] = address(i + 1);
}
puppyRaffle.enterRaffle{value: entranceFee * NUMBER_OF_PLAYERS}(players);
_;
}
function testWithdrawFeesDOS() public playersEnteredMore {
vm.warp(block.timestamp + duration + 1);
vm.roll(block.number + 1);
uint256 expectedPrizeAmount = ((entranceFee * NUMBER_OF_PLAYERS) * 20) / 100;
puppyRaffle.selectWinner();
console.log("puppyRaffle balance = %uint", uint64(address(puppyRaffle).balance));
console.log("puppyRaffle totalFees = %uint", puppyRaffle.totalFees());
puppyRaffle.withdrawFees();
assertEq(address(feeAddress).balance, expectedPrizeAmount);
}
Impact
Impossible to withdraw fees.
Tools Used
Foundry
Recommendations
Make totalFees uint256 value.
Updates
Lead Judging Commences
Hamiltonite over 1 year ago
Submission Judgement Published Assigned finding tags:
unsafe cast of fee to uint64
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.