Submission Details
Severity:
`Puppy Raffle::selectWinner()` check not present
Summary
Puppy Raffle::selectWinner() if a check is not added for entrance fee. total fees can be 0, which can lead to function fail
Vulnerability Details
@> uint256 totalAmountCollected = players.length * entranceFee;
uint256 prizePool = (totalAmountCollected * 80) / 100;
uint256 fee = (totalAmountCollected * 20) / 100;
totalFees = totalFees + uint64(fee);
Impact
Function fail
Tools Used
Manual Review
Recommendations
add a check before totalAmountCollected ofPuppy Raffle::selectWinner()
- uint256 totalAmountCollected = players.length * entranceFee;
+ require(entranceFee>0,"inadequate entrance fee");
+ uint256 totalAmountCollected = players.length * entranceFee;
Updates
Lead Judging Commences
patrickalphac almost 2 years ago
Submission Judgement Published Reason: User experience and design improvement
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.