Submission Details
Severity:
`PuppyRaffle:: _isActivePlayer` is declared but never called making it unusable
Summary
_isActivePlayer is an internal function of contract which is never called.
Vulnerability Details
Avoid having any code that is not being used, as that will reduce the overall code size and less gas consumption during deployment.
Impact
It does not impact working of contract in any way.
Tools Used
Manual Review
Recommendations
Remove this function from code base or make it an external view function so people can use it.
function _isActivePlayer() external view returns (bool) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
}
}
return false;
}
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.