Submission Details
Severity:
Fee should be 'totalAmountCollected-prizePool' to prevent decimal loss
Summary
fee should be 'totalAmountCollected-prizePool' to prevent decimal loss
Vulnerability Details
uint256 totalAmountCollected = players.length * entranceFee;
uint256 prizePool = (totalAmountCollected * 80) / 100;
uint256 fee = (totalAmountCollected * 20) / 100;
This formula calculates fee should be 'totalAmountCollected-prizePool'
Impact
By calculates fee like the formula above can cause a loss in totalAmountCollected' if the prizePool` is rounded.
Tools Used
Manual
Foundry
Recommendations
- uint256 fee = (totalAmountCollected * 20) / 100;
+ uint256 fee = totalAmountCollected-prizePool;
Updates
Lead Judging Commences
patrickalphac over 1 year ago
Submission Judgement Published Assigned finding tags:
loss of precision
like 1 wei
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.