Submission Details
Severity:
Wrong in determining `rarity`
Summary
Wrong in determining the rarity
Vulnerability Details
else if (rarity <= COMMON_RARITY + RARE_RARITY) to calculate the rare rarity is wrong
This else if statement to calculate rare rarity is not true because it makes the rare rarity likely to happen more than the COMMON_RARITY
Impact
Causes the RARE_RARITY' happens more than COMMON_RARITYmakes raffle become very easy to draw aRARE_RARITY=> causes a lot of money for paying that kind of rarity` to the user.
Tools Used
Manual
Foundry
Recommendations
if (rarity <= COMMON_RARITY) {
tokenIdToRarity[tokenId] = COMMON_RARITY;
- } else if (rarity <= COMMON_RARITY + RARE_RARITY) {
+ else if ( COMMON_RARITY<rarity<=COMMON_RARITY + RARE_RARITY) {
//BUG COMMON_RARITY<rarity<=COMMON_RARITY + RARE_RARITY
tokenIdToRarity[tokenId] = RARE_RARITY;
} else {
tokenIdToRarity[tokenId] = LEGENDARY_RARITY;
}
Updates
Lead Judging Commences
Hamiltonite over 1 year ago
Submission Judgement Published Assigned finding tags:
wrong nft rarity
71% 25% 4%
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.