Submission Details
Severity:
USELESS_MAXDELAY_CHECK
Summary
Uint256 is checked to be not less than zero but uint256 can't be less than zero
Vulnerability Details
In function addTokenMaxDelay where maxDelay has type uint256 there is condition maxDelay < 0
function addTokenMaxDelay(address token, uint256 maxDelay) external onlyOwner {
...
if (maxDelay < 0) revert Errors.TokenPriceFeedMaxDelayMustBeGreaterOrEqualToZero();
This condition is always false as maxDelay can't be less than 0
Impact
Gas spent for useless check as well as for error Errors.TokenPriceFeedMaxDelayMustBeGreaterOrEqualToZero storing
Tools Used
Recommendations
Do not check unsigned variables to be < 0
Updates
Lead Judging Commences
hans about 2 years ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
INFO: Unnecessary maxDelay/maxDeviation check
Redundant check on maxDelay and/or maxDeviation in ARBOracle
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915
USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.