Submission Details
Severity:
USELESS_MAXDEVIATION_CHECK
Summary
Uint256 variable maxdeviation is checked to be not less than zero but uint256 can't be less than zero
Vulnerability Details
In function addTokenMaxDeviation where maxDeviation has type uint256 there is condition maxDeviation < 0
function addTokenMaxDeviation(address token, uint256 maxDeviation) external onlyOwner {
...
if (maxDeviation < 0) revert Errors.TokenPriceFeedMaxDeviationMustBeGreaterOrEqualToZero();
This condition is always false as maxDeviation can't be less than 0
Impact
Gas spent for useless check as well as for error Errors.TokenPriceFeedMaxDeviationMustBeGreaterOrEqualToZero storing
Tools Used
Recommendations
Do not check unsigned variables to be < 0
Updates
Lead Judging Commences
hans over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
INFO: Unnecessary maxDelay/maxDeviation check
Redundant check on maxDelay and/or maxDeviation in ARBOracle
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915 USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.