Beginner FriendlyFoundryBridge
100 EXP
View results
Submission Details
Severity: high
Valid

Arbitrary SafeTransfer Function in Deposit

Summary

safeTransferFrom() called in the depositTokensToL2() function allows for the passing of an arbitrary 'from' address.

Vulnerability Details

If user1 has approved token transfer to the vault contract, then other approved users can call eg.. deposit(user1, userx, 100) in order to steal tokens from user1, deposit them to the bridge and have the corresponsing L2 tokens minted on userx address.

Impact

direct stealing of funds

Tools Used

Recommendations

change the 'from' address parameter to msg.sender

Updates

Lead Judging Commences

0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

depositTokensToL2(): abitrary from address

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.