Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

SantaList default value is NICE

Summary

NICE is the first value in the status enum

Vulnerability Details

If the address is never checked by Santa, the user will be able to collect a present.

Impact

Users can mint NFT's without being checked.

Tools Used

Foundry/Remix

Recommendations

Reorder the enum so NOT_CHECKED_TWICE is the first value, or any value other than those able to claim NFT.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

default status is nice

In Solidity the first element of an enum is the default value. In Santa's List, the means each person is mapped by default to 'NICE'.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.