Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Valid

PURCHASED_PRESENT_COST not set

Summary

The cost to purchase a present is supposed to be 2e18 but it only requires having 1e18 tokens to burn.

Vulnerability Details

The cost of a present is half of what it's meant to be.

Impact

Price control PURCHASED_PRESENT_COST is not implemented

Tools Used

Foundry

Recommendations

Require the balance of SantaToken is >= PURCHASED_PRESENT_COST parameter in the buyPresent function.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Price is not enforced in buyPresent

This line indicates that the intended cost of presents for naughty people should be 2e18: https://github.com/Cyfrin/2023-11-Santas-List/blob/6627a6387adab89ae2ba2e82b38296723261c08a/src/SantasList.sol#L87 PURCHASE_PRESENT_COST should be implemented to enforce the cost of presents.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.