Submission Details
Severity:
getCalculatedFee can be 0
Summary
getCalculatedFee can be as low as 0
Vulnerability Details
Any value up to 333 for "amount" can result in 0 fee based on calculation
function testFuzzGetCalculatedFee() public {
AssetToken asset = thunderLoan.getAssetFromToken(tokenA);
uint256 calculatedFee = thunderLoan.getCalculatedFee(
tokenA,
333
);
assertEq(calculatedFee ,0);
console.log(calculatedFee);
}
Impact
Low as this amount is really small
Tools Used
Foundry, Manual review
Recommendations
A minimum fee can be used to offset the calculation, though it is not that important.
Rewards breakdown
nSLOC
387This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.