Submission Details
Severity:
getCalculatedFee in USDC will amount to 0
Summary
getCalculatedFee in USDC will amount to 0 because of the precision (s_feePrecision=1e18)
For example Zilliqa will also have the same problem, because it has 12 decimals precision.
Vulnerability Details
At the current moment 1 usdc = 0.000527 WETH
So when calculating the valueOfBorrowedToken we will have:
Lets say I borrow 1 000 000USDC
1 000 000*10e6 * 0.000527 / 1e18
527 / 1e12 = 0
Impact
High as Fee will be 0 and that will amount to losses to the protocol
Tools Used
Manual review
Recommendations
s_feePrecision should be based on the token we are using
Rewards breakdown
nSLOC
387This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.