No storage gaps for upgradeable contracts might lead to storage slot collision
Summary
When implementing upgradable contracts that inherit it is important that there are storage gaps, incase new storage variables are later added to the inherited contracts. If a storage gap variable isn't added, when the upgradable contract introduces new variables ,it may override the variables in the inheriting contract. https://docs.openzeppelin.com/upgrades-plugins/1.x/writing-upgradeable#modifying-your-contracts
Tools Used
Manual Analysis
Recommendations
It is recommended to add a state variable named __gap as a reserved space
for future upgrades in every upgradeable contract
Lead Judging Commences
storage-gap
Lack of storage gaps in SDLPool might impact storage of SDLPoolPrimary and SDLPoolSecondary if new storage introduced in future.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.