Submission Details
Severity:
Code does not follow the best practice of check-effects-interaction
Summary
Code does not follow the best practice of check-effects-interaction
Vulnerability Details
Code should follow the best-practice of check-effects-interaction, where state variables are updated before any external calls are made. Doing so prevents a large class of reentrancy bugs.
Impact
Instances (3):
File: contracts/core/ccip/SDLPoolCCIPControllerPrimary.sol
/// @audit handleOutgoingRESDL called prior to this assignment
114: reSDLSupplyByChain[_destinationChainSelector] += reSDLToken.amount + reSDLToken.boostAmount;
/// @audit safeTransfer called prior to this assignment
133: reSDLSupplyByChain[_sourceChainSelector] -= _reSDLToken.amount + _reSDLToken.boostAmount;
File: contracts/core/ccip/SDLPoolCCIPControllerSecondary.sol
/// @audit safeTransfer called prior to this assignment
157: if (ISDLPoolSecondary(sdlPool).shouldUpdate()) shouldUpdate = true;
Tools Used
Recommendations
Prize pool breakdown
Total prize
27,500 USDC
nSLOC
1,41419 USDC / LOC
25,000 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.