Submission Details
Severity:
Large approvals may not work with some `ERC20` tokens
Summary
Large approvals may not work with some ERC20 tokens
Vulnerability Details
Not all IERC20 implementations are totally compliant, and some (e.g UNI, COMP) may fail if the valued passed is larger than uint96. Source
Impact
Instances (5):
File: contracts/core/ccip/SDLPoolCCIPControllerPrimary.sol
193: IERC20(_tokens[i]).safeApprove(router, type(uint256).max);
File: contracts/core/ccip/WrappedTokenBridge.sol
71: linkToken.approve(_router, type(uint256).max);
72: token.approve(_wrappedToken, type(uint256).max);
File: contracts/core/ccip/base/SDLPoolCCIPController.sol
52: linkToken.approve(_router, type(uint256).max);
53: sdlToken.approve(_router, type(uint256).max);
Tools Used
Recommendations
Prize pool breakdown
Total prize
27,500 USDC
nSLOC
1,41419 USDC / LOC
25,000 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.