stake.link

Summary

contracts/core/ccip/base/SDLPoolCCIPController.sol#130-132
contracts/core/ccip/base/SDLPoolCCIPController.sol#138-140
contracts/core/ccip/SDLPoolCCIPControllerPrimary.sol#234-236
In Ethereum, it is considered a best practice to emit events when modifying the state of a contract through setter functions (functions that modify or update the contract's state).

Vulnerability Details

The functions setRESDLTokenBridge and setMaxLINKFee within the SDLPoolCCIPController.sol contract are setter functions but do not emit any events.
Events are crucial as they allow users and other contracts to know when and how the state of a contract changes. This makes it easier to track changes and updates on the blockchain since events can be listened to outside the contract and are used to notify other contracts or applications about significant changes.

Impact

Disinformation about the contract's state

Tools Used

Audit Wizard, slither

Recommendations

The given recommendation suggests that in the setRESDLTokenBridge and setMaxLINKFee functions, an event emission should be included to notify interested parties about the update of the associated token bridge value. Adding an event in such functions helps maintain transparency and communication on the Ethereum network.

In summary, to adhere to best practices, it is suggested to add an event emission at the end of the setRESDLTokenBridge and setMaxLINKFee functions to inform about the changes made in the contract.