stake.link

stake.link
DeFiHardhatBridge
27,500 USDC
View results
Submission Details
Severity: low
Valid

Use two-step ownership transfers instead of single-step ownership transfers

Vulnerability Details

Single-step ownership transfers add the risk of setting an unwanted owner by accident (this includes
address(0)) if the ownership transfer is not done with excessive care.

Context: LinearBoostController.sol

10 contract LinearBoostController is Ownable

Similar Findings:

  1. https://solodit.xyz/issues/l-07-use-ownable2step-instead-of-ownable-for-access-control-code4rena-particle-protocol-particle-protocol-invitational-git

  2. https://solodit.xyz/issues/l-04-use-code4rena-redacted-cartel-redacted-cartel-contest-git

Impact

If the new address is inactive or not willing to act, there is no way to restore access to that role. Therefore, the owner role can be lost.

Tools

Manual Review

Recommendation

It is recommended to use the Ownable2Step library instead of Ownable library

Updates

Lead Judging Commences

0kage Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

ownable-2step

have a 2-step owner transfer

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.