Submission Details
Severity:
Reduce Redundant Balance Checks
Instead of calling tokenToTransfer.balanceOf(address(this)) within the loop for each token, we can call it once per token, store it in a local variable, and then use the variable for the transfer. This reduces the number of external calls to the token contract.
Also if the balance is zero, we can skip the transfer call altogether, saving gas.
function recoverTokens(address[] calldata _tokens, address _receiver) external onlyOwner {
require(_receiver != address(0), "Invalid receiver address");
for (uint256 i = 0; i < _tokens.length; ++i) {
address tokenAddress = _tokens[i];
require(tokenAddress != address(0), "Token address cannot be zero");
IERC20 tokenToTransfer = IERC20(tokenAddress);
uint256 tokenBalance = tokenToTransfer.balanceOf(address(this));
if (tokenBalance > 0) {
tokenToTransfer.safeTransfer(_receiver, tokenBalance);
}
}
}
Prize pool breakdown
Total prize
27,500 USDC
nSLOC
1,41419 USDC / LOC
25,000 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.