Submission Details
Severity:
Unfair fee distribution because of `LiquidationPoolManager::setPoolFeePercentage`
Vulnerability Details
Holders deposit money because of these fees and they consider the poolFeePercentage when investing. If this poolFeePercentage drops, holders' trust will decrease.
Pool's fee calculation made here and as you can see if poolFeePercentage is decreased _feesForPool is also decreased.
Impact
If poolFeePercentage changes the fee distribution will be unfair.
Tools Used
Manual Review
Recommendations
Calculate fees separately: fee(old poolFeePercentage)+ fee(new poolFeePercentage).
Updates
Lead Judging Commences
hrishibhat almost 2 years ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
informational/invalid
emrekocak
almost 2 years ago
hrishibhat
almost 2 years ago
hrishibhat
almost 2 years ago
hrishibhat almost 2 years ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933
USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.