The Standard

DeFiHardhat

20,000 USDC

View results

Previous Next

Submission Details

Severity: low

Invalid

Low issues

favelanky

Implement time delay

It is recommended to add time delays when making significant changes to state variables. The absence of time delays may impact the user experience and trust in the project. By incorporating time delays, users are given a period to react to the changes, leading to better communication and increased trust in the project.

There are 12 instance of this issue:

File: contracts/LiquidationPoolManager.sol

84: function setPoolFeePercentage(uint32 _poolFeePercentage) external onlyOwner {

84.

File: contracts/SmartVaultManagerV5.sol

103: function setMintFeeRate(uint256 _rate) external onlyOwner {

107: function setBurnFeeRate(uint256 _rate) external onlyOwner {

111: function setSwapFeeRate(uint256 _rate) external onlyOwner {

115: function setWethAddress(address _weth) external onlyOwner() {

119: function setSwapRouter2(address _swapRouter) external onlyOwner() {

123: function setNFTMetadataGenerator(address _nftMetadataGenerator) external onlyOwner() {

127: function setSmartVaultDeployer(address _smartVaultDeployer) external onlyOwner() {

131: function setProtocolAddress(address _protocol) external onlyOwner() {

135: function setLiquidatorAddress(address _liquidator) external onlyOwner() {

103, 107, 111, 115, 119, 123, 127, 131, 135.

File: contracts/SmartVaultV3.sol

114: function liquidate() external onlyVaultManager {

233: function setOwner(address _newOwner) external onlyVaultManager {

114, 233.

Functions that alter state should emit events

Functions that alter state should emit events to notify users of the state change. This is especially important for functions that alter state and do not return a value.