The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

SmartVaultManagerV5 does not have collateralRate setter

Summary

SmartVaultManagerV5 does not have collateralRate setter, which can either inhibit protocol or lead to user loss of funds.

Vulnerability Details

collateralRate is neither not set in constructor, nor does it have a setter function, like other parameters of the protocol, e.g. rates. It means it has default value of 0, which can lead to negative consequences.

Impact

If used in proxying, this can lead to contract redeployment.
If deployed anew/raw, users can send funds with intention to mint() stablecoins, but they won't be able to since 0 collateralRate will lead to 0 division error in maxMintable() function in SmartVaultV3.

Tools Used

Manual

Recommendations

Implement setters/default value for collateralRate, depending on intention.

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.