The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Unnecessary Casting

Summary

An unnecessary casting was found in the SmartVaultManagerV5 contract which would spend more gas than needed.

Similar findings from other contests/audits:

  • https://code4rena.com/reports/2023-04-frankencoin#g-06-unnecessary-casting-as-variable-is-already-of-the-same-type

  • https://solodit.xyz/issues/nmkt-8-unnecessary-casting-guardian-audits-none-nftr-markdown

Vulnerability Details

The _from argument from function _afterTokenTransfer() should not be cast to address as it is already as an address.

Impact

The contract might spend unnecessary gas by casting an address that is already an address.

Tools Used

Manual Analysis.

Recommendations

Consider removing the redundant cast to save gas.

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.