The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

malicious Owner can modify fee rates on existing vaults to get more benefit

Summary

The vulnerability exposes the risk of a malicious owner manipulating fee rates on existing vaults within the SmartVaultManagerV5 contract. This adjustment allows the owner to potentially increase their Euro yield by exploiting high-value transactions and adjusting fee rates in their favor.

Vulnerability Details

In the SmartVaultManagerV5 contract, the fee rates, namely mintFeeRate, burnFeeRate, and swapFeeRate, are susceptible to modification at any time by the owner after users have created SmartVaults. This adjustment is facilitated by functions such as the following example:

uint256 public mintFeeRate;
uint256 public burnFeeRate;
uint256 public swapFeeRate;
function setMintFeeRate(uint256 _rate) external onlyOwner {
mintFeeRate = _rate;
}

Impact

If the owner acts maliciously or is compromised, they can exploit the system by waiting for a mint transaction with a significant amount, the owner can front-run the transaction and utilize the setMintFeeRate() function to modify the mintFeeRate to a higher value. This manipulation allows the owner to gain more value and potentially reduce the max mintable amount for the user.

Tools Used

Manual inspection

Recommendations

To enhance security, it is advised to set the fee rates with fixed values during the initialization phase and eliminate the set functions. Alternatively, if dynamic configuration of fee rates is essential, especially when uniformity exists across all vaults, establish these rates at the time of vault deployment for each specific vault.

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.