The Standard
The Standard
DeFiHardhat
20,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Lack of event emission for vital state change

Obin

Summary

contracts/SmartVaultManagerV5.sol is lacking event emission for critical state changes.

Vulnerability Details

contracts\SmartVaultManagerV5.sol is a contract used directly by end users via the mint function to deploy vaults. Parameters such as address public smartVaultDeployer; (for instance) is heavily crucial for this mint().
That said, if such a parameter is to be altered by the protocol, its vital for such state change to be published onchain.

Note that this also applies to other vital parameter changes listed below:

  • function setMintFeeRate(), function setBurnFeeRate(), function setSwapFeeRate(), function setWethAddress(), function setSwapRouter2(), function setNFTMetadataGenerator(), function setProtocolAddress(), and function setLiquidatorAddress()

Impact

Lack of broadcast for vital state change

Tools Used

Manual Review

Recommendations

+ event SmartVaultDeployerChanged(address old, address new);
​
function setSmartVaultDeployer(address _smartVaultDeployer) external onlyOwner() {
+ emit setSmartVaultDeployer(smartVaultDeployer,_smartVaultDeployer);
smartVaultDeployer = _smartVaultDeployer;
}
​
Updates

Lead Judging Commences

hrishibhat Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

events

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!