The current implementation of SmartVault3#setOwner
allows the vaultManager to change the new owner of the vault at any time, even if the vault owners have paid back their debt, and their vault remains healthy. Although it was mentioned that the admin is trusted, it's advisable to impose certain limitations.
Vault owners can loose access to their vaults at any moment.
Manual
Consider adding a function to setOwner
that allows only the vaultManager to change the owner only when the vault is liquidated or undercollateralized.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.