The Standard
The Standard
DeFiHardhat
20,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Ambiguous Variable Names in `SmartVaultManagerV5`

n0kto

Description

The variable names protocol and liquidator in SmartVaultManagerV5 both store the same address, leading to potential confusion. Additionally, the variable name weth is used to represent the wrapped native token, which might be misleading.

@> address public protocol;
@> address public liquidator;

Impact

The ambiguous variable names may cause confusion during development or future code reviews. It could lead individuals to believe that tokens are sent to the protocol team or that only WETH is used as the native wrapped token.

Recommended Mitigation

  • For the protocol variable, either set it to address(0) or the actual protocol multisig wallet. Modify all other contracts to use liquidator to avoid any confusion.

  • Rename the weth variable to wrappedNativeAddress without changing the type or order to avoid breaking upgrades. Refactor all other contracts accordingly.

Updates

Lead Judging Commences

hrishibhat Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!