Summary

chainLink pricefeed can result price as zero in some conditions,No check for RoundCompleteness could lead to stale prices or outdated price.

Vulnerability Details

On ChainlinkPriceOracle.sol, we are using latestRoundData, but there is no check if the return value indicates stale data

https://docs.chain.link/docs/historical-price-data/#historical-rounds
https://docs.chain.link/docs/faq/#how-can-i-check-if-the-answer-to-a-round-is-being-carried-over-from-a-previous-round

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L218

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L207

Tools Used

Manual

Recommendations

Consider adding missing checks for stale data.