The Standard

Summary

Hardcoded uniswap fees significantly the possibilities and can lead to non optimal routes.

Vulnerability Details

In SmartVaultV3 contract, swap funtion is used to swap tokens, and constructs ISwapRouter.ExactInputSingleParams, using fixed fee 3000 (0.3%) level:

However, not all pools in Uniswap are created with fee level being 3000, some are 10000, some 500; THis can case that the swap pool might not exist. ALso, the available pool of that fee level might not be the most optimal, it could be a low liwuidity pool.

Impact

Loss of funds, incomplete transactions, inability to correctly make swaps.

Tools Used

Manual code review

Recommendations

Replace the 3000 parameter with fee and allow owner to pass the fee in a parameter.