Summary

Rewards will be inaccurate due to division before multiplication in calculations.

Vulnerability Details

When calculating costInEuros, many multiplications and divisions are done without order:

This is problematic as it will result in the value of costInEuros being rounded down, which could affect the value of _portion:

Since _portion is the value used to allocate rewards this will result in inaccurate allocations and stakers receiving bigger allocations which means the protocol is losing money everytime the distributeAssets() function is called.

Impact

Inaccurate allocation of rewards to stakers and loss of money to the protocol.

Tools Used

Manual review.

Recommendations

Ensure multiplication is done first before any sort of division: