Submission Details
Severity:
decreasePosition() does not follow CEI pattern
Vulnerability Details
When decreasing position, TST and EUROs tokens are transferred first before updating state to decrease balance of holder. This is essentially doing Interactions before Effects which is not best practice.
Impact
Low
Tools Used
Manual Review.
Recommendations
Do state changes before transferring tokens.
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Too generic
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.