There are two kinds of modifier usage in SmartVaultManagerV5
, onlyOwner
and onlyOwner()
Accroding to the form 's answer .
https://ethereum.stackexchange.com/questions/152224/solidity-modifier-attachment-expression-onlyowner-vs-onlyowner-any-differenc
onlyOwner
and onlyOwner()
are same effect .
brackets are more often used when we need to pass arguments to the modifier. Else normally we don't use brackets.
There is no parameters required here, so we are more inclined to use onlyOwner
.
https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/SmartVaultManagerV5.sol#L111-L117
Different code specifications will influence the code 's robustness and readability
Mannual Review, VScode
Unify the standard of modifier and only use onlyOwner
here .
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.