Submission Details
Severity:
Potential Collision on Reward index
Summary
Vulnerability Details
The reward are stored in the mapping mapping(bytes => uint256) private rewards; and the index is calculated with rewards[abi.encodePacked(user, token.symbol)];
When there are token with same symbol, the reward mapping will be messed up.
Impact
Collision on reward index can be generated, which will mess the reward records, for example, two tokens will share the same storage:
rewards[abi.encodePacked(_position.holder, asset.token.symbol)] += _portion;
Tools Used
Manual
Recommendations
Recommend reconsider the index calculation for rewards mapping, for example, using token address instead.
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.