The Standard
The Standard
DeFiHardhat
20,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing event makes it harder to keep track of things happening off-chain.

0xluckyluke

Summary

The LiquidationPool contract lacks event emissions in LiquidationPool::holderPendingStakes and LiquidationPool::addUniqueHolder functions, resulting in a transparency gap for on-chain state changes.

Vulnerability Details

The LiquidationPool::holderPendingStakes and LiquidationPool::addUniqueHolder functions, responsible for modifying critical contract parameters, addresses, or states, do not emit events. This absence prevents off-chain monitors and tools from promptly registering updates and reacting to crucial changes.

Impact

The missing event emissions reduce on-chain transparency, potentially leading to oversights and difficulties in tracking contract behavior for off-chain components.

Tools Used

Manual

Recommendations

Event Emission:
Integrate event emissions within LiquidationPool::holderPendingStakes and LiquidationPool::addUniqueHolder functions to record critical changes on-chain, enabling better off-chain monitoring and reaction capabilities.

+ event holderPendingStakesUpdated(address indexed user, uint256 newPosition);
+ event UniqueHolderAdded(address indexed user, uint256 newPosition);
+ // Add relevant events for other critical changes
Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

events

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.