Submission Details
Severity:
Using `block.timestamp` for swap deadline offers no protection
Summary
block.timestamp is used as the deadline for swaps in SmartVaultV3::swap() L223.
Vulnerability Details
In the PoS model, proposers know well in advance if they will propose one or consecutive blocks ahead of time. In such a scenario, a malicious validator can hold back the transaction and execute it at a more favorable block number.
Impact
This offers no protection as block.timestamp will have the value of whichever block the tx is inserted into, hence the tx can be held indefinitely by malicious validators.
Tools Used
Manual review
Recommendations
Consider allowing function caller to specify swap deadline input parameter.
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
deadline-check-low
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.