Submission Details
Severity:
Code does not follow the best practice of check-effects-interaction
Summary
Code should follow the best-practice of check-effects-interaction, where state variables are updated before any external calls are made.
Vulnerability Details
File: contracts/LiquidationPool.sol
/// @audit - State change after external call: `IERC20(TST).safeTransfer(msg.sender, _tstVal)`
155: positions[msg.sender].TST -= _tstVal
/// @audit - State change after external call: `IERC20(EUROs).safeTransferFrom(msg.sender, address(this), _amount)`
188: positions[_holder].EUROs += _amount * positions[_holder].TST / tstTotal
Tools Used
VSCode
Recommendations
Rewrite the code to follow the CEI pattern
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.