The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

A ISmartVaultManagerV5 should be used instead of ISmartVaultManagerV3

Summary

The smart contract incorrectly uses an outdated interface ISmartVaultManagerV3 instead of the latest version ISmartVaultManagerV5. This issue is classified as LOW severity due to its nature of referencing an older interface version.

It could be misleading for future implementation and leads to errors / confusion for users or contract maintainer

Vulnerability Details

The function getTokenManager, maxMintable, liquidateNative, liquidateERC20, mint, burn, getSwapAddressFor, executeNativeSwapAndFee, executeERC20SwapAndFee, calculateMinimumAmountOut, swap in the SmartVaultV3 contract references to ISmartVaultManagerV3(manager) for fetching constants and performing calculations.

The use of an older interface version (V3) instead of the latest version (V5) can lead to discrepancies in calculations or functionalities that rely on updated contract logic or parameters present in ISmartVaultManagerV5.

Impact

This issue, while relatively minor, could lead to potential functional or security concerns:

Future Compatibility: Continual use of outdated interfaces can hinder the contract's ability to integrate with newer versions of related contracts or protocols, potentially leading to compatibility issues.

Security Risks: If ISmartVaultManagerV5 contains security enhancements or bug fixes not present in V3, the contract may be exposed to vulnerabilities that have already been addressed in the newer version.

Tools Used

Manual Code Review: The issue was identified through a direct examination of the provided contract code.

Recommendations

Update Interface Reference: Replace all instances of ISmartVaultManagerV3 with ISmartVaultManagerV5 to ensure the contract is interacting with the latest version of the interface. Even if the new interface doesn't include new methods

Updates

Lead Judging Commences

hrishibhat Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.