The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Unnecessary checkings

Vulnerability Details

In the "consolidatePendingStakes()" function the for loop executes all through the pending stakes althought the if condition return false. After the 'if condition' returns false we can return the execution because the pending stakes are pushed to the array based on the time when they were staked
So if the "if" condition returns false then there is no probability for the second stake deposited time is less than the the stake which was returned false.

Impact

Gas

Tools Used

Manual review

Recommendations

return the loop when the if condition retutns false

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.