The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Unchecked Return Values of the `approve()` Function, transactions may silently proceed

Summary

There is no guarantee that ITokenManager::getAcceptedTokens() will return ERC20s with the same approve behavior.

Vulnerability Details

The unchecked return value of the approve() method can potentially cause transaction failures to go unnoticed in your contract.

Some IERC20 token implementations utilize boolean return values to indicate transaction failures, instead of relying on the revert() function. If the return value of the approve() method isn't appropriately verified, transactions may seemingly proceed even when the necessary token approvals have not been appropriately executed.

File: contracts/LiquidationPoolManager.sol
76: ierc20.approve(pool, erc20balance);

Tools Used

VSCode

Recommendations

Add a check o value returned by the approve() function

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.