Submission Details
Severity:
Gas Griefing Due to Non-Handling of Return Data from an arbitrary address
Summary
SmartVaultV3::removeCollateralNative() sends ETH to an arbitrary _to address, which could be a smart contract that returns a huge amount of data.
Vulnerability Details
Due to the EVM architecture, return data (bool success,) has to be stored.
So if an arbitrary address returns an enormous amount of data protocol will pay gas for storing this data in memory.
File: contracts/SmartVaultV3.sol
137: (bool sent,) = _to.call{value: _amount}("");
Tools Used
VSCode
Recommendations
Consider using a safe call pattern above to avoid these issues.
assembly {
success: = call(gas(), dest, amount, 0, 0)
}
require(success, "transfer failed");
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.