The Standard
The Standard
DeFiHardhat
20,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Stakers will not get the actual fee earned when pool fee percentage is changed

abiih

Summary

Stakers will not get the actual fee earned when pool fee percentage is changed

Vulnerability Details

There is a setPoolFeePercentage function in the protocol that changes the pool fee percentage. Changes happens directly and this might result in not getting the actual fee earned.Suppose, when fee percentage is changed from 5 percent to 10 percent then the staker will loose the accumulated fee. Stakers should get the fee accumulated when the percentage was 10 but instead they get at the rate of 5.

Impact

Stakers will not get the actual fee earned

Tools Used

Manual Review

Recommendations

First distribute the fee and then only change the fee percentage

function setPoolFeePercentage(uint32 _poolFeePercentage) external onlyOwner {
+ distributeFees();
poolFeePercentage = _poolFeePercentage;
}
Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.