Submission Details
Severity:
Wrong slippage protection on Token
Summary
SmartVaultV3 doesn't respect users' slippage specifications and allows more slippage than is requested
Vulnerability Details
The function calculateMinimumAmountOut tries to culculate minAmount despite the fact that a user provided minAmount while calling the swap
function calculateMinimumAmountOut(bytes32 _inTokenSymbol, bytes32 _outTokenSymbol, uint256 _amount) private view returns (uint256) {
Impact
At the end of the swap users will end up receiving less tokens than they asked for due to slippage.
Tools Used
Manual Review
Recommendations
Make use of user-specified slippage parameters
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Lack of quality
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.