Submission Details
Severity:
Missing Chain ID Checks in `tokenURI()`
Summary
Consider adding require(1 == chain.chainId) or the chain ID of the preferred chain to the detected
functions, or at least include the chain ID in the URI to eliminate confusion regarding which chain owns
the NFT.
File: contracts/SmartVaultManagerV5.sol
93: function tokenURI(uint256 _tokenId) public view virtual override returns (string memory) {
ISmartVault.Status memory vaultStatus = ISmartVault(smartVaultIndex.getVaultAddress(_tokenId)).status();
return INFTMetadataGenerator(nftMetadataGenerator).generateNFTMetadata(_tokenId, vaultStatus);
}
Tools Used
VSCode
Recommendations
Include the chain ID in tokenURI
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.