The Standard

Summary

In the swap functionality the fee value in the params is hardcoded, this can lead to situations where swaps cannot be proccessed because of low fees sent, cause uniswap and other AMMs fees are not fixed fees and can change depending on the pool activites.

Vulnerability Details

When implementing the swap functionality, in the Smart vault contract the fee in the params for the swap is harcoded as shown below

Impact

Inabilty of the swap function to conduct operations, if the hardcoded fees in the params are not enough to perform the swap

Tools Used

Manual Review

Recommendations

Most AMMs implement a getter function that provides information about how much fees a user has to pay to conduct swaps in a particular pool, i think that should be implemented, to get an accurate description of the fee amount that will require to conduct a successful swap.